Skip to content

Fix #12477 [Dump] Added additional Info to the dump file for suppressions#6050

Merged
danmar merged 5 commits intocppcheck-opensource:mainfrom
wienans:feature/dump-suppression
Mar 8, 2024
Merged

Fix #12477 [Dump] Added additional Info to the dump file for suppressions#6050
danmar merged 5 commits intocppcheck-opensource:mainfrom
wienans:feature/dump-suppression

Conversation

@wienans
Copy link
Copy Markdown
Contributor

@wienans wienans commented Feb 27, 2024

For Reference see here: https://sourceforge.net/p/cppcheck/discussion/development/thread/55941f914e/

Added the type, line begin and line end to the suppression file so addons have improved use of suppressions

Comment thread lib/suppressions.cpp Outdated
@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Feb 27, 2024

I have created this ticket:
https://trac.cppcheck.net/ticket/12477

Please write "Fix #12477..." as PR title.

@wienans wienans changed the title [Dump] Added additional Info to the dump file for suppressions Fix #12477 [Dump] Added additional Info to the dump file for suppressions Feb 27, 2024
@wienans wienans force-pushed the feature/dump-suppression branch from 8124566 to 3442fc2 Compare February 28, 2024 14:59
@wienans wienans force-pushed the feature/dump-suppression branch from b0fb042 to 238d8bc Compare February 28, 2024 15:55
@wienans wienans requested a review from danmar February 28, 2024 16:04
@wienans
Copy link
Copy Markdown
Contributor Author

wienans commented Feb 28, 2024

@danmar added strings as output for the type and also the restructured the method to check for a match in python.
It was getting very hard to understand the logic so i split it up in 3 blocks

hope it is okay now

@wienans wienans force-pushed the feature/dump-suppression branch from 10828cb to c29f8ed Compare February 28, 2024 17:05
@wienans
Copy link
Copy Markdown
Contributor Author

wienans commented Feb 28, 2024

Changed the tests for Misra suppression to also use the new feature partly to test both features.

@wienans
Copy link
Copy Markdown
Contributor Author

wienans commented Mar 2, 2024

Hey @danmar is there any chance this PR is reviewed / merged in the next days? I would love to use this feature at work an wanted to only build / deploy binaries after it is approved so I don’t need to do it multiple times. 🙈 if not it’s okay too, then I will think about if I want to do the builds and deployment for work twice, but in both cases feedback would be nice.

@danmar danmar merged commit 7e42652 into cppcheck-opensource:main Mar 8, 2024
@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Mar 8, 2024

@wienans sorry for the delay. I merged this now. Thanks!

@wienans wienans deleted the feature/dump-suppression branch March 8, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants