Some shellcheck fixes

[orbitcowboy]

No description provided.

[firewave]

We have shellcheck in the CI but currently have several checks disabled. If you think there is something worth enabling please do so that it is actually enforced. These are mainly disabled because the step existed since quite a while but did not fail when it raised a warning so most were disabled instead of fixing them.

[orbitcowboy]

We have shellcheck in the CI but currently have several checks disabled. If you think there is something worth enabling please do so that it is actually enforced. These are mainly disabled because the step existed since quite a while but did not fail when it raised a warning so most were disabled instead of fixing them.

Yes, I saw that we have mostly deactivated it. There are a lot of portability warnings from shellcheck that can be fixed, especially in this script. On the long run, I think it's a good attitude to become (mostly) shellcheck clean in our scripts as well.

[firewave]

Yes, I saw that we have mostly deactivated it. There are a lot of portability warnings from shellcheck that can be fixed, especially in this script. On the long run, I think it's a good attitude to become (mostly) shellcheck clean in our scripts as well.

Enabling them just one at a time also gets us there at the end.

Just be sure to test it. I (barely) remember that it had some false positives which actually broke scripts. That has been ages ago so those might have been fixed since.