Codecov v4

[danmar]

v3 has problems with uploading results. That should be fixed in v4.

[firewave]

The issue is that v3 uses the v4 API which requires a token. So updating it to v4 should do not anything.

Installing the codecov app for the repo might fix this this. See https://trac.cppcheck.net/ticket/12112.

[danmar]

The issue is that v3 uses the v4 API which requires a token

codecov v3 uses codecov v4 API?

didn't you mean it uses github v4 API?

[danmar]

I was inspired by this:
kubeedge/kubeedge#5530

and hoped the same would work for us.

[firewave]

See codecov/codecov-action#1359 for the upstream issue. And https://github.com/codecov/codecov-action?tab=readme-ov-file#v4-release for the release notes.

[danmar]

See codecov/codecov-action#1359 for the upstream issue. And https://github.com/codecov/codecov-action?tab=readme-ov-file#v4-release for the release notes.

Well the upload worked.
https://github.com/danmar/cppcheck/actions/runs/8644847325/job/23700822390?pr=6271

at least as far as I can tell.

[firewave]

That is really strange. It should permanently fail with v4 because we have no token. Something is very wrong there. And still not having a single reply is also not comforting (there are very few replies to issues with that action in general).

So go ahead with the update to v4.

[firewave]

Still fails but in a different way:

==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit --git-service github -Z
gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" imported
gpg: Total number processed: 1
gpg:               imported: 1

gpg: Signature made Wed Apr 10 17:26:31 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869

==> Uploader SHASUM verified (2c9804ba263ba6880d67a671c35388a72fbfe014bd814acd212d8ff38644bf91  codecov)
info - 2024-04-11 14:14:42,614 -- ci service found: github-actions
Error: Codecov token not found. Please provide Codecov token with -t flag.
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

That's obviously the error you get when there is no token - as pointed out by the v4 release notes. So the issue with v3 is something different.

[danmar]

I'm sad that it didn't work after all :-(

Thanks for your fix.