Fixed #12504 (dumpfile: usage of relative paths is inconsistent)

[danmar]

No description provided.

[firewave]

I encountered similar issues with #6182.

I am considering adding a Path class so we have consistent paths being used throughout the code. We keep converting and normalizing all over the place and multiple times. That could also be merged with/into FileSettings which would solve a few more problems. That needs some refactoring/cleanups first though.

[danmar]

I am considering adding a Path class so we have consistent paths being used throughout the code.

That sounds like a good idea imho. Sounds like it could be more type safe also.

[firewave]

That sounds like a good idea imho. Sounds like it could be more type safe also.

FileSettings would essentially become PathWithDetails and you pass that around instead. A light version will be introduced when I post the PR for https://trac.cppcheck.net/ticket/10692 so we do not try to identify an input file more than once.