Skip to content

added FileWithDetails to store resolved input path in#6285

Merged
firewave merged 5 commits intocppcheck-opensource:mainfrom
firewave:path-details
Apr 21, 2024
Merged

added FileWithDetails to store resolved input path in#6285
firewave merged 5 commits intocppcheck-opensource:mainfrom
firewave:path-details

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

@firewave firewave changed the title added PathWithDetails to store input path in added PathWithDetails to store resolved input path in Apr 12, 2024
@firewave firewave force-pushed the path-details branch 2 times, most recently from 38e4f73 to d7fe55b Compare April 15, 2024 07:43
@firewave
Copy link
Copy Markdown
Collaborator Author

This is the initial step so we start out with the (currently) basic wrapper. We need to adjust the code to pass that instead of of a simple string and we can add details and more logic along the way.

The aim is to have merged PathWithDetails with FileSettings at the end so we only have a single list to pass around.

Comment thread tools/dmake/dmake.cpp
return err;

// add *.cpp files to the "files" vector..
for (const std::pair<const std::string&, size_t> file : filelist) {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous type was wrong and there was also an unnecessary copy which was not detected by clang-tidy.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Apr 16, 2024

I think it would be better to call it FileWithDetails as it will only contain files.

@firewave firewave force-pushed the path-details branch 3 times, most recently from bc20feb to 132f60e Compare April 16, 2024 07:05
@firewave firewave changed the title added PathWithDetails to store resolved input path in added FileWithDetails to store resolved input path in Apr 16, 2024
@firewave firewave marked this pull request as ready for review April 16, 2024 07:50
@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Apr 18, 2024

This is quite a large refactoring. Please do not merge before the release.

@firewave firewave added the merge-after-next-release Wait with merging this PR until after the next Release label Apr 18, 2024
@firewave
Copy link
Copy Markdown
Collaborator Author

This is quite a large refactoring. Please do not merge before the release.

As this doesn't change any logic at all it is not really that big of a change. I am fine with delaying this nevertheless.

Comment thread cli/cmdlineparser.cpp Outdated
@firewave firewave removed the merge-after-next-release Wait with merging this PR until after the next Release label Apr 21, 2024
Copy link
Copy Markdown
Collaborator

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@firewave firewave merged commit ea2e716 into cppcheck-opensource:main Apr 21, 2024
@firewave firewave deleted the path-details branch April 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants