Skip to content

Fix #12363 FP unreadVariable with unknown constructor that takes a parameter #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Apr 18, 2024
Merged

Fix #12363 FP unreadVariable with unknown constructor that takes a parameter #6305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
064235b
Update checkunusedvar.cpp
chrchr-github Apr 18, 2024
e25dd24
Update testunusedvar.cpp
chrchr-github Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/checkunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,7 +1214,9 @@ void CheckUnusedVar::checkFunctionVariableUsage()
const bool isPointer = tok->valueType() && (tok->valueType()->pointer || tok->valueType()->type == ValueType::SMART_POINTER);

if (tok->isName()) {
if (isRaiiClass(tok->valueType(), tok->isCpp(), false))
if (isRaiiClass(tok->valueType(), tok->isCpp(), false) ||
(tok->valueType() && tok->valueType()->type == ValueType::RECORD &&
(!tok->valueType()->typeScope || !isRecordTypeWithoutSideEffects(tok->valueType()->typeScope->definedType))))
continue;
tok = tok->next();
}
Expand Down
7 changes: 7 additions & 0 deletions test/testunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ class TestUnusedVar : public TestFixture {
TEST_CASE(localvar68);
TEST_CASE(localvar69);
TEST_CASE(localvar70);
TEST_CASE(localvar71);
TEST_CASE(localvarloops); // loops
TEST_CASE(localvaralias1);
TEST_CASE(localvaralias2); // ticket #1637
Expand Down Expand Up @@ -3906,6 +3907,12 @@ class TestUnusedVar : public TestFixture {
ASSERT_EQUALS("", errout_str());
}

void localvar71() {
functionVariableUsage("struct A { explicit A(int i); };\n" // #12363
"void f() { A a(0); }\n");
ASSERT_EQUALS("", errout_str());
}

void localvarloops() {
// loops
functionVariableUsage("void fun(int c) {\n"
Expand Down