added --debug-lookup to log library loading

[firewave]

No description provided.

[firewave]

A few thoughts:

• we are putting a hard-coded path in the binary and nowhere it is visible to the user. We should have a way to expose this so it can be used by the test as well as viewed by others. e.g. --show-filesdir
• should we make it possible to disable the usage of the built-in path (because it is hard-coded and cannot be changed by the user)? e.g. --disable-filesdir
• we should document which paths are used for looking up the libraries (and all other files). I have not checked yet if it already is.

[firewave]

Only the sanitizer builds fail so we can simply disable FILESDIR in those jobs.

[firewave]

FILESDIR cannot be overridden in a CMake build right now and is always set by default. In a Makefile it is not set by default and can be overriden.

[danmar]

FILESDIR cannot be overridden in a CMake build right now and is always set by default.

sounds like a "bug" hope that can be fixed. the intention is that it will only be set if the package maintainer wants to set a hardcoded path. For instance in windows it should not be set. In my humble opinion --disable-filesdir does not sound related it is the package installation script duty to install cppcheck properly

[firewave]

FILESDIR cannot be overridden in a CMake build right now and is always set by default.

sounds like a "bug" hope that can be fixed.

That was already fixed by #6437.

the intention is that it will only be set if the package maintainer wants to set a hardcoded path. For instance in windows it should not be set.

We do set that for the official packages.

In my humble opinion --disable-filesdir does not sound related it is the package installation script duty to install cppcheck properly

This is more a thing about safety as this hard-coded path (currently also invisible to the user) cannot be controlled. It should be the last one in the lookup order so it is basically just a fall-through but still.

But none of this is scope of this PR. That should be tracked via tickets.

[firewave]

So can this be merged? This is the required baseline for fixing issues/doing cleanups.

[firewave]

I filed https://trac.cppcheck.net/ticket/12810 and https://trac.cppcheck.net/ticket/12811 about adding the proposed options.

[danmar]

looks good.. I am not against this --debug-lookup. I just have a question.

[danmar]

Is there a particular reason to define FILESDIR here.

[firewave]

Yes. Because it is set by default in CMake but not with make the tests will only work on either. For now I have omitted it from testing. This is one of the reasons an option to disable the usage of the built-in path would make sense.