Fix #12798: Add inline supression to projectDialog#6453
Merged
danmar merged 9 commits intocppcheck-opensource:mainfrom May 31, 2024
Merged
Fix #12798: Add inline supression to projectDialog#6453danmar merged 9 commits intocppcheck-opensource:mainfrom
danmar merged 9 commits intocppcheck-opensource:mainfrom
Conversation
danmar
reviewed
May 27, 2024
Collaborator
|
I would like that you add a test in cppcheck/test/testimportproject.cpp |
danmar
requested changes
May 28, 2024
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I have the feeling that the flag can be configured. But it's not used in the analysis. I think you should tweak the MainWindow::getCppcheckSettings()
I don't know.. we could in theory keep the setting in the SettingsDialog but only use that when the ProjectFile is null. I don't have a very strong opinion.
danmar
reviewed
May 29, 2024
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I believe you need to update getCppcheckSettings in mainwindow.cpp also
danmar
reviewed
May 30, 2024
olabetskyi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.