scriptcheck.yml: re-enabled pylint and mitigated findings / added missing files to Python syntax and lint check#6464
Merged
firewave merged 6 commits intocppcheck-opensource:mainfrom Jun 11, 2024
Conversation
firewave
commented
May 31, 2024
| def report(directive,msg,errorId,column=0): | ||
| reportNamingError(directive,msg,errorId,column=column) | ||
| def report(directive,msg,errorId,severity='style',column=0): | ||
| reportNamingError(directive,msg,errorId,severity=severity,column=column) |
Collaborator
Author
There was a problem hiding this comment.
@thingsconnected FYI - introduced in 8261ded.
firewave
commented
May 31, 2024
| def process(dumpfiles, configfile): | ||
| conf = loadConfig(configfile) | ||
|
|
||
| # pylint: disable-next=no-member - TODO: fix this |
Collaborator
Author
There was a problem hiding this comment.
@thingsconnected I do not understand why this is not triggered for the other cases where this class is used.
firewave
commented
May 31, 2024
| # pylint: disable-next=no-member - TODO: fix this | ||
| if conf.include_guard: | ||
| global include_guard_header_re | ||
| # pylint: disable-next=no-member - TODO: fix this |
Collaborator
Author
There was a problem hiding this comment.
@thingsconnected see above
firewave
commented
May 31, 2024
| full_path = os.path.join(path, file) | ||
| path, filename = os.path.split(full_path) | ||
|
|
||
| cwd = os.getcwd() |
Collaborator
Author
Collaborator
There was a problem hiding this comment.
yeah I agree chdir() should not be used if it can be avoided. :-(
firewave
commented
May 31, 2024
| self.insert_in_dict(extern_var_without_def, tok.str, tok) | ||
| else: | ||
| self.insert_in_dict(extern_var_without_def, var.nameToken.str, var.nameToken) | ||
| self.insert_in_dict(extern_var_without_def, var.nameToken.str, var.nameToken) |
Collaborator
Author
Collaborator
Author
|
@thingsconnected still two warnings I have not fixed yet: |
Collaborator
Author
|
I addressed all findings. |
firewave
force-pushed
the
pylint-xx
branch
3 times, most recently
from
28f93bb to
f00c7c4
Compare
danmar
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.