Skip to content

limit usage of internal in selfchecks to files which are being matchcompiled#6473

Merged
firewave merged 1 commit intocppcheck-opensource:mainfrom
firewave:selfcheck-internal
Jul 29, 2024
Merged

limit usage of internal in selfchecks to files which are being matchcompiled#6473
firewave merged 1 commit intocppcheck-opensource:mainfrom
firewave:selfcheck-internal

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Jun 1, 2024

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Jun 1, 2024

There is actually a check which is not dependent on the matchcompiler. checkRedundantNextPrevious() will detect redundant patterns when working on tokens. But I think it should be fine since such code is not being used outside of lib and I think there is no need to apply it to the test code.

@firewave firewave force-pushed the selfcheck-internal branch from 58f95a8 to 4aeea69 Compare July 29, 2024 06:36
@firewave firewave merged commit 3edeccb into cppcheck-opensource:main Jul 29, 2024
@firewave firewave deleted the selfcheck-internal branch July 29, 2024 12:17
@firewave
Copy link
Copy Markdown
Collaborator Author

Splitting cli from lib in the scanning has the unfortunately side effect that the selfcheck is now busy with cli/cmdlineparser.cpp which is the longest file and will no longer process the lib files on the other process. That causes the selfcheck to be slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants