Skip to content

Fix #12383: cppcheck build dir: changed line numbers in source file#6505

Merged
olabetskyi merged 3 commits intocppcheck-opensource:mainfrom
olabetskyi:lines_fix
Jun 11, 2024
Merged

Fix #12383: cppcheck build dir: changed line numbers in source file#6505
olabetskyi merged 3 commits intocppcheck-opensource:mainfrom
olabetskyi:lines_fix

Conversation

@olabetskyi
Copy link
Copy Markdown
Collaborator

I added comparison of both lines and columns so if any exta spaces/new lines were added we can adjus our report accordingly

@firewave
Copy link
Copy Markdown
Collaborator

Please add a test for this.

Comment thread lib/preprocessor.cpp Outdated
@olabetskyi olabetskyi marked this pull request as ready for review June 11, 2024 11:24
Copy link
Copy Markdown
Collaborator

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@olabetskyi olabetskyi merged commit ea2c390 into cppcheck-opensource:main Jun 11, 2024
@olabetskyi olabetskyi deleted the lines_fix branch June 11, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants