Fix #8159 FN unusedFunction: sole recursive call

[chrchr-github]

No description provided.

[firewave]

Maybe also add the missing cond variable when fixing this up.

[firewave]

Ah - too late.

[chrchr-github]

cond could be an unknown global variable.
The return2() test is not compilable though.

[chrchr-github]

Do we want to keep MathLib::isDigitSeparator()? It's only used in tests.
clangimport::AstNode::dumpAst() has a deactivated call somewhere. Should we remove that?
Token::astStringZ3() is useful for testing.

[firewave]

Do we want to keep MathLib::isDigitSeparator()? It's only used in tests.

The logic was apparently moved to simplecpp in 03d2829 shortly after it was added in 3095f47. So we should remove it.

clangimport::AstNode::dumpAst() has a deactivated call somewhere. Should we remove that? Token::astStringZ3() is useful for testing.

Add suppressions for these for now with comments which indicate how they are (not) used.

[chrchr-github]

We have a bunch of code that deals with "markup files". Is this tested explicitly anywhere?

[firewave]

We have a bunch of code that deals with "markup files". Is this tested explicitly anywhere?

That is tested in test/cli/qml_test.py.

[chrchr-github]

We have a bunch of code that deals with "markup files". Is this tested explicitly anywhere?

That is tested in test/cli/qml_test.py.

I see, thanks. That's one of the reasons for using strings to identify functions instead of Function*. More reasons are templates, and multiple file handling.