Skip to content

refs #12836 - added Python tests showing inline suppressions not working with unusedFunction check and -j2#6522

Merged
chrchr-github merged 1 commit intocppcheck-opensource:mainfrom
firewave:py-unused
Jun 13, 2024
Merged

refs #12836 - added Python tests showing inline suppressions not working with unusedFunction check and -j2#6522
chrchr-github merged 1 commit intocppcheck-opensource:mainfrom
firewave:py-unused

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

This was extracted from #5647.

@chrchr-github
Copy link
Copy Markdown
Collaborator

If this highlights a bug, shouldn't we add a TODO somewhere?

@firewave
Copy link
Copy Markdown
Collaborator Author

If this highlights a bug, shouldn't we add a TODO somewhere?

This is no single location to highlight this. It's a fundamental problem. The referenced PR partially fixes this but that is not mergable and still quite messy.

I am trying to establish a basic test coverage so I can start fixing this. There are also still potentially more bugs related to this.

@chrchr-github
Copy link
Copy Markdown
Collaborator

What I meant was, is it obvious that this is an undesirable test result? Elsewhere we have e.g. TODO_ASSERT. But I'm not familiar with those Python tests.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Jun 13, 2024

What I meant was, is it obvious that this is an undesirable test result? Elsewhere we have e.g. TODO_ASSERT. But I'm not familiar with those Python tests.

That is reflected by @pytest.mark.xfail(). That indicates that this test is expected to fail for now (reported as XFAIL). If the test should ever succeed that will be reported as XPASS. Since it set the strict option this will cause the Python test will fail with an error.

@chrchr-github chrchr-github merged commit 43b4b70 into cppcheck-opensource:main Jun 13, 2024
@firewave firewave deleted the py-unused branch June 13, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants