Add extra information to directives#6527
Merged
olabetskyi merged 12 commits intocppcheck-opensource:mainfrom Jun 19, 2024
Merged
Add extra information to directives#6527olabetskyi merged 12 commits intocppcheck-opensource:mainfrom
olabetskyi merged 12 commits intocppcheck-opensource:mainfrom
Conversation
olabetskyi
commented
Jun 14, 2024
danmar
reviewed
Jun 14, 2024
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
some test will be needed.
Collaborator
|
I think that the lifetime of simplecpp tokens is limited. If you store simplecpp token pointers this class is not safe for some possible use cases. |
Collaborator
|
I don't remember how the location is set.. what is the output for this macro? |
Collaborator
Author
I would need to recheck but it's all on one line |
danmar
reviewed
Jun 18, 2024
danmar
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.