Skip to content

Fix #12916 False positive: negative shift in macro (string << i) #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Jul 11, 2024
Merged

Fix #12916 False positive: negative shift in macro (string << i) #6581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85e31b5
Update checkother.cpp
chrchr-github Jul 9, 2024
1a29cd9
Update testother.cpp
chrchr-github Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/checkother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2999,7 +2999,7 @@ void CheckOther::checkNegativeBitwiseShift()
// don't warn if lhs is a class. this is an overloaded operator then
if (tok->isCpp()) {
const ValueType * lhsType = tok->astOperand1()->valueType();
if (!lhsType || !lhsType->isIntegral())
if (!lhsType || !lhsType->isIntegral() || lhsType->pointer)
continue;
}

Expand Down
7 changes: 7 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9113,6 +9113,13 @@ class TestOther : public TestFixture {
"[test.cpp:2]: (error) Shifting by a negative value is undefined behaviour\n"
"[test.cpp:3]: (portability) Shifting a negative value is technically undefined behaviour\n"
"[test.cpp:4]: (portability) Shifting a negative value is technically undefined behaviour\n", errout_str());

check("void f(int i) {\n" // #12916
" if (i < 0) {\n"
" g(\"abc\" << i);\n"
" }\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void incompleteArrayFill() {
Expand Down