Fix 13143: False positive: misra 14.1 (i < n) && (x[i] > last)#6838
Merged
danmar merged 1 commit intocppcheck-opensource:mainfrom Oct 5, 2024
Merged
Fix 13143: False positive: misra 14.1 (i < n) && (x[i] > last)#6838danmar merged 1 commit intocppcheck-opensource:mainfrom
danmar merged 1 commit intocppcheck-opensource:mainfrom
Conversation
danmar
reviewed
Sep 27, 2024
swasti16
force-pushed
the
swasti/13143
branch
from
c0bc452 to
594d20a
Compare
danmar
reviewed
Sep 28, 2024
swasti16
force-pushed
the
swasti/13143
branch
2 times, most recently
from
0cdfccf to
effbc08
Compare
danmar
reviewed
Oct 2, 2024
| if not counterToken.valueType or not counterToken.valueType.isFloat(): | ||
| continue | ||
| if token.isAssignmentOp and token.astOperand1.str == counterToken.str: | ||
| if token.str not in tok_str: |
Collaborator
There was a problem hiding this comment.
hmm the old code only matched the token string but that is unfortunate.
we should not determine that f is a loop counter here:
void foo(void)
{
int i = 0;
float f = 0;
while (f < 10 && i < 10) {
float f = 0; f = f + i;
i++;
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.