added environment variable TEST_CPPCHECK_INJECT_BUILDDIR to inject --cppcheck-build-dir into the cppcheck invocation of Python tests#6876
Merged
firewave merged 2 commits intocppcheck-opensource:mainfrom Dec 5, 2024
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
firewave
changed the title
TEST_CPPCHECK_INJECT_BUILDDIR to inject …TEST_CPPCHECK_INJECT_BUILDDIR to inject --cppcheck-build-dir into the cppcheck invocation of Python tests
Collaborator
Author
|
So far I still stand by my previous comment that the build dir should not be used in production ... if all tests pass with the option injected I will most likely change my opinion. |
firewave
force-pushed
the
inject-builddir
branch
from
5f2495f to
391c952
Compare
This comment was marked as resolved.
This comment was marked as resolved.
firewave
force-pushed
the
inject-builddir
branch
3 times, most recently
from
edb18d6 to
b326a34
Compare
Collaborator
Author
This looks better than expected and I take back my previous opinion. There are still documented issues but those don't look too bad. |
firewave
force-pushed
the
inject-builddir
branch
2 times, most recently
from
1e331b3 to
2c7cd3c
Compare
firewave
force-pushed
the
inject-builddir
branch
2 times, most recently
from
3acd18b to
f8aff8e
Compare
firewave
force-pushed
the
inject-builddir
branch
3 times, most recently
from
5b079a0 to
5305980
Compare
firewave
force-pushed
the
inject-builddir
branch
from
5305980 to
35af33b
Compare
…`--cppcheck-build-dir` into the cppcheck invocation of Python tests
firewave
force-pushed
the
inject-builddir
branch
from
35af33b to
4f8040e
Compare
danmar
approved these changes
Dec 5, 2024
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I like the idea to run the tests with and without build dir 👍
Collaborator
Author
Wait til you see the follow-up... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.