release-windows.yml: fixed collecting files [skip ci]

[firewave]

No description provided.

[firewave]

https://github.com/danmar/cppcheck/actions/runs/11283837769/job/31383985732

Run move build\bin\Release win_installer\files || exit /b !errorlevel!
        1 dir(s) moved.
A subdirectory or file win_installer\files\addons already exists.

No idea how this broke because it was working fine within the PR but now fails with

[firewave]

No idea how this broke because it was working fine within the PR but now fails with

This broke because of #6882. Which is actually good as it exposed redundant code.

[firewave]

Successful build: https://github.com/danmar/cppcheck/actions/runs/11296554734?pr=6904.

[firewave]

This obliterated the whole CI...

[firewave]

Sh... how can we restore the history?!?!?!? Please do not push anything to the master.

@chrchr-github @orbitcowboy @pfultz2

@danmar I might need owner permissions to fix this.

[firewave]

@ludviggunne forgot to mention you - please do not merge anything.

[firewave]

The GitHub Desktop application let's me squash commits and apparently force-push (whereas my IDE doesn't).

So I could easily fix that if given the OK.

The amount of people which have pulled the change into their fork is extremely small so the fallout should minimal.

Although @danmar pointed out that it will most likely break daca. I will take care of that by introducing a workaround. That is not good but it would get rid of the outdated clients (which I would have preferred to do in a different way).

[danmar]

I don't see how to give you write permission.

[danmar]

I could drop the commit from the history if you like. git rebase and drop.

I will take care of that by introducing a workaround.

I am not sure how it can be worked around.. do you suggest that the donate-cpu.py script will automatically restore the repo. but donate-cpu.py scripts must still be restarted in some way, right?

[firewave]

I am not sure how it can be worked around.. do you suggest that the donate-cpu.py script will automatically restore the repo. but donate-cpu.py scripts must still be restarted in some way, right?

Yes. Users need to update it - but most of them usually do. In #6455 I outline how users gain an "auto-update".

[danmar]

Users need to update it - but most of them usually do.

but this time it will not work well with a "git pull". I assume they use "git pull".

[firewave]

but this time it will not work well with a "git pull". I assume they use "git pull".

So far it is very few people which are affected (only six people outside of the team so far got the bad change) so it should not be an issue getting the script but within the script itself which I will address.

[danmar]

I have dropped the commit so now you can try to fix.

[firewave]

I have dropped the commit so now you can try to fix.

That already fixed it. I will prepare a new PR which fixed the release job.

Everybody else - please rebase and drop the now stray commit from your branches.

[firewave]

@olabetskyi @jhnc-oss @MatrixMike @rghe @makesoftwaresafe @sthagen

I tagged you in this ticket to inform you that we had to drop the commit for this MR from the main branch and perform a force-push because it removed files it shouldn't have and we would have lost the revision history (i.e. git blame) otherwise (see above). I am sincerely apologize for any problems caused by this and hope things can be resolved fast and easily.

So far it seems you simply need to drop the commit in question from your up-to-date branches and everything should be fine.

I will try to help out as much as I can if further issues arise.

[sthagen]

@firewave thanks.

[firewave]

#6917 fixes the daca client.