Skip to content

run all Qt-based tests (in CI) #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
firewave merged 3 commits into from
Jan 23, 2025
Merged

run all Qt-based tests (in CI) #6916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f3d62a
run Qt-based tests which require an display with `offscreen` platform
firewave Oct 14, 2024
562bfbd
fixed expected result in `test-translationhandler`
firewave Oct 14, 2024
6dc11d0
disabled `test-resultstree` since it might crash
firewave Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gui/test/resultstree/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
endif()

if (REGISTER_GUI_TESTS)
# TODO: does not work in the CI
# add_test(NAME test-resultstree COMMAND $<TARGET_FILE:test-resultstree>)
# TODO: might crash - see #13223
#add_test(NAME test-resultstree COMMAND $<TARGET_FILE:test-resultstree> -platform offscreen)
endif()

add_dependencies(gui-tests test-resultstree)
3 changes: 1 addition & 2 deletions gui/test/translationhandler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
endif()

if (REGISTER_GUI_TESTS)
# TODO: requires X session - run with QT_QPA_PLATFORM=offscreen?
#add_test(NAME test-translationhandler COMMAND $<TARGET_FILE:test-translationhandler>)
add_test(NAME test-translationhandler COMMAND $<TARGET_FILE:test-translationhandler> -platform offscreen)
endif()

add_dependencies(gui-tests test-translationhandler)
2 changes: 1 addition & 1 deletion gui/test/translationhandler/testtranslationhandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ static QStringList getTranslationNames(const TranslationHandler& handler)
void TestTranslationHandler::construct() const
{
TranslationHandler handler;
QCOMPARE(getTranslationNames(handler).size(), 13); // 12 translations + english
QCOMPARE(getTranslationNames(handler).size(), 15); // 14 translations + english
QCOMPARE(handler.getCurrentLanguage(), QString("en"));
}

Expand Down