fixed #13238 - GUI: Fix start application with Qt6#6931
Merged
firewave merged 1 commit intocppcheck-opensource:mainfrom Oct 17, 2024
Merged
fixed #13238 - GUI: Fix start application with Qt6#6931firewave merged 1 commit intocppcheck-opensource:mainfrom
firewave merged 1 commit intocppcheck-opensource:mainfrom
Conversation
Contributor
Author
|
Open GUi tickets isn't working. I was not able to search for an already open ticket. |
luis-pereira
force-pushed
the
fix-start-application-qt6
branch
from
3c1a7b4 to
65c6b9e
Compare
Collaborator
|
Thanks for your contribution. They flip-flopped on this by deprecating it in Qt5 and then no longer deprecating in Qt6 (see comment) above so I didn't pay much attention on what is actually going on here. Having matching signatures between those two versions is obviously a really bad decision. I also added some other comment. |
firewave
changed the title
firewave
reviewed
Oct 17, 2024
Collaborator
|
I tested the changes locally and can confirm that it fixes the issue. I also filed a ticket about it. |
It doesn't work with Qt6.
Qt5 QProcess::startDetached(const QString &command) was removed and replaced
with:
QProcess::startDetached(const QString &program, const QStringList &arguments = {},
const QString &workingDirectory = QString(),
qint64 *pid = nullptr)
Due to Qt6 default arguments, build doesn't break but we end up feeding it
the wrong arguments.
luis-pereira
force-pushed
the
fix-start-application-qt6
branch
from
65c6b9e to
c94d305
Compare
ludviggunne
pushed a commit
to ludviggunne/cppcheck
that referenced
this pull request
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't work with Qt6.
Qt5
QProcess::startDetached(const QString &command)was removed and replaced with:QProcess::startDetached(const QString &program, const QStringList &arguments = {}, const QString &workingDirectory = QString(), qint64 *pid = nullptr)Due to Qt6 default arguments, build doesn't break but we end up feeding it the wrong arguments.