Skip to content

Fixed #13323 (building triage tool)#7018

Merged
danmar merged 1 commit intocppcheck-opensource:mainfrom
cppchecksolutions:fix-13323
Nov 18, 2024
Merged

Fixed #13323 (building triage tool)#7018
danmar merged 1 commit intocppcheck-opensource:mainfrom
cppchecksolutions:fix-13323

Conversation

@danmar
Copy link
Copy Markdown
Collaborator

@danmar danmar commented Nov 17, 2024

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator

??? It is part of the CMake project. Just build the triage target. It is awkwardly conditional behind the BUILD_TESTS define though which I will change soon.

@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Nov 18, 2024

Well this will make it possible to build the triage tool directly and easily.

We can certainly keep the cmake building also and use that for the CI.

@danmar danmar merged commit f9cfcbd into cppcheck-opensource:main Nov 18, 2024
@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Nov 18, 2024

It is part of the CMake project.

I don't see a strong reason why it's part of the cmake project. This is only intended to be a developer tool not something users should see.

We could have a standalone cmake in triage folder that would be easier to build for us imho and for users they will have 1 fewer option when building cppcheck?

@firewave
Copy link
Copy Markdown
Collaborator

I don't see a strong reason why it's part of the cmake project. This is only intended to be a developer tool not something users should see.

Because that is our main build system. That's why it should be disabled by default (changes coming up).

We could have a standalone cmake in triage folder that would be easier to build for us imho and for users they will have 1 fewer option when building cppcheck?

That would increase the maintenance burden and add additional steps to the CI and the point is getting rid of unnecessary redundancies which detract from actually useful work.

If you really need it separate you can maintain it in a fork but it does not make sense to have it in the repo.

@firewave
Copy link
Copy Markdown
Collaborator

Well this will make it possible to build the triage tool directly and easily.

Then we need to revert everything related to qmake because we need to make sure it kept up-to-date and builds.

@danmar danmar deleted the fix-13323 branch December 1, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants