Skip to content

Fix #13332 FP eraseDereference for iterator in array #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orbitcowboy merged 2 commits into from
Nov 25, 2024
Merged

Fix #13332 FP eraseDereference for iterator in array #7039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6beba2
Update checkstl.cpp
chrchr-github Nov 25, 2024
3f3e3dc
Update teststl.cpp
chrchr-github Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/checkstl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ void CheckStl::iterators()
const int iteratorId = var->declarationId();

// the validIterator flag says if the iterator has a valid value or not
bool validIterator = Token::Match(var->nameToken()->next(), "[(=:{]");
bool validIterator = Token::Match(var->nameToken()->next(), "[(=:{[]");
const Scope* invalidationScope = nullptr;

// The container this iterator can be used with
Expand Down
7 changes: 7 additions & 0 deletions test/teststl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5155,6 +5155,13 @@ class TestStl : public TestFixture {
" *it;\n"
"}\n");
ASSERT_EQUALS("", errout_str());

check("int g() {\n" // #13332
" const std::vector<int> v = { 1, 2, 3, 4 };\n"
" const std::vector<int>::const_iterator a[2] = { v.begin(), v.end() };\n"
" return *a[0];\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void dereferenceInvalidIterator2() {
Expand Down