Skip to content

fixed #13365 - addons/test/util.py: got rid of non-portable commands #7064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
firewave merged 2 commits into from
Dec 5, 2024
Merged

fixed #13365 - addons/test/util.py: got rid of non-portable commands #7064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b1e640
fixed #13365 - addons/test/util.py: got rid of non-portable commands
firewave Dec 3, 2024
417f130
misra_test.py: removed unnecessary `dump_remove()` call from `test_ru…
firewave Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion addons/test/misra_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ def test_rules_suppression(checker, capsys):

for src in test_sources:
re_suppressed= r"\[%s\:[0-9]+\]" % src
dump_remove(src)
dump_create(src, "--suppressions-list=addons/test/misra/suppressions.txt","--inline-suppr")
checker.parseDump(src + ".dump")
captured = capsys.readouterr().err
Expand Down
5 changes: 1 addition & 4 deletions addons/test/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,10 @@ def dump_create(fpath, *argv):
p.communicate()
if p.returncode != 0:
raise OSError("cppcheck returns error code: %d" % p.returncode)
with subprocess.Popen(["sync"]) as p:
p.communicate()


def dump_remove(fpath):
with subprocess.Popen(["rm", "-f", fpath + ".dump"]) as p:
p.communicate()
os.remove(fpath + ".dump")


def convert_json_output(raw_json_strings):
Expand Down