Skip to content

Fix duplicate findtoken.h in lib/cppcheck.vcxproj#7193

Merged
firewave merged 6 commits intocppcheck-opensource:mainfrom
chrchr-github:chr_proj
Jan 8, 2025
Merged

Fix duplicate findtoken.h in lib/cppcheck.vcxproj#7193
firewave merged 6 commits intocppcheck-opensource:mainfrom
chrchr-github:chr_proj

Conversation

@chrchr-github
Copy link
Copy Markdown
Collaborator

No description provided.

@chrchr-github chrchr-github changed the title Fix cppcheck.vcxproj [skip ci] Fix duplicate findtoken.h in lib/cppcheck.vcxproj Jan 8, 2025
@chrchr-github
Copy link
Copy Markdown
Collaborator Author

The web editor has helpfully added a newline...

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Jan 8, 2025

The web editor has helpfully added a newline...

That is why you are not supposed to edit these files manually. That's the job of dmake 😃

BTW I was not even aware you could edit files and create commits. That might have been very helpful in the past.

@chrchr-github
Copy link
Copy Markdown
Collaborator Author

chrchr-github commented Jan 8, 2025

That is why you are not supposed to edit these files manually. That's the job of dmake 😃

Thanks. But that would mean running dmake first, and the project file was recently removed (I know there are other ways to compile it)...

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Jan 8, 2025

Thanks. But that would mean running dmake first, and the project file was recently removed (I know there are other ways to compile it)...

It was never integrated properly either. It one of the many downsides of using the provided Visual Studio project.

The CI is using MinGW on Windows. I thought there might be a one-liner for Visual Studio users.

@firewave firewave merged commit 01b6141 into cppcheck-opensource:main Jan 8, 2025
ludviggunne pushed a commit to ludviggunne/cppcheck that referenced this pull request Jan 11, 2025
…e#7193)

Co-authored-by: Oliver Stöneberg <firewave@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants