small Check::analyseWholeProgram() related cleanup

[firewave]

No description provided.

[firewave]

The application code was never omitting the ctu parameter so no need for having it as a pointer.

[danmar]

nice!

[danmar]

It would be nice to have a cppcheck check that could detect such pointer arguments. :-)

Maybe not easy to implement, we did pass a nullptr in the testclass.

[firewave]

It would be nice to have a cppcheck check that could detect such pointer arguments. :-)

There is a ticket about detected unchecked dereferences - but that would not have fired either.

Maybe not easy to implement, we did pass a nullptr in the testclass.

That's why it is good to have an analysis run without the tests included - see the CI run of unusedFunction to detect code only used in tests. Might make sense to include that into the security guide.

[firewave]

The case with unchecked parameters is covered by https://trac.cppcheck.net/ticket/11566.

CLion/Rider has a warning if a parameter is always the same value. That would related to an seemingly invalid enhancement request I filed in https://trac.cppcheck.net/ticket/13531.

[firewave]

CLion/Rider has a warning if a parameter is always the same value

Actually Cppcheck also has this as knownArgument.

[firewave]

Actually Cppcheck also has this as knownArgument.

Actually that only seems to trigger in very specific cases.