Skip to content

fixed #13506 - fixed tokenizing of +-prefixed numbers in conditions#7230

Merged
orbitcowboy merged 2 commits into
cppcheck-opensource:mainfrom
firewave:plus-prefix
Jan 18, 2025
Merged

fixed #13506 - fixed tokenizing of +-prefixed numbers in conditions#7230
orbitcowboy merged 2 commits into
cppcheck-opensource:mainfrom
firewave:plus-prefix

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

Hacked in the additional handling so it behaves as expected.
@pfultz2 @chrchr-github please have a look

Comment thread lib/tokenize.cpp Outdated
@firewave firewave changed the title fixed #13506 - fixed tokenizing of +-prefixed numbers in conditions refs #13506 - fixed tokenizing of +-prefixed numbers in conditions Jan 16, 2025
@firewave firewave marked this pull request as ready for review January 16, 2025 18:22
@firewave firewave marked this pull request as draft January 16, 2025 18:23
@firewave
Copy link
Copy Markdown
Collaborator Author

There is still a testcase which is not detected. I have not looked at it yet and I might split it into another ticket.

@firewave
Copy link
Copy Markdown
Collaborator Author

There is still a testcase which is not detected. I have not looked at it yet and I might split it into another ticket.

It was again the case where knownConditionTrueFalse can come from two different checks.

@firewave firewave changed the title refs #13506 - fixed tokenizing of +-prefixed numbers in conditions fixed #13506 - fixed tokenizing of +-prefixed numbers in conditions Jan 16, 2025
@firewave firewave marked this pull request as ready for review January 16, 2025 19:01
@orbitcowboy orbitcowboy merged commit 6d3b47c into cppcheck-opensource:main Jan 18, 2025
@firewave firewave deleted the plus-prefix branch January 18, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants