Fix #13647: Misra C 21.6: Location should point at function call instead of #include#7355
Merged
danmar merged 1 commit intocppcheck-opensource:mainfrom Mar 11, 2025
Merged
Conversation
Contributor
|
I would suggest to make it dependent on C standard. this PR will fix many missing Identifieres and add the new once from C11. Therefore C standard dependence would be a good thing. there is already a Funktion isStdLibId, but that would check if the token.str is within any of the library header files. |
swasti16
force-pushed
the
swasti/13647_21.6
branch
2 times, most recently
from
18123e6 to
3638fd9
Compare
danmar
reviewed
Mar 9, 2025
swasti16
force-pushed
the
swasti/13647_21.6
branch
3 times, most recently
from
cb9c0bb to
b643467
Compare
danmar
reviewed
Mar 9, 2025
| continue | ||
| standard_id = getStdLib(data.standards.c) | ||
| funcname = token.previous.str | ||
| if "stdio.h" in standard_id.keys() and funcname in standard_id["stdio.h"]: |
Collaborator
There was a problem hiding this comment.
I'd suggest:
Suggested change
| if "stdio.h" in standard_id.keys() and funcname in standard_id["stdio.h"]: | |
| if funcname in standard_id.get("stdio.h", []): |
swasti16
force-pushed
the
swasti/13647_21.6
branch
from
b643467 to
15e5015
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.