templatesimplifier.cpp: fixed clang-analyzer-alpha.core.Conversion warning in getTemplateInstantiations()#7384
Merged
firewave merged 1 commit intocppcheck-opensource:mainfrom Mar 27, 2025
Conversation
Collaborator
firewave
commented
Mar 19, 2025
firewave
commented
…warning in `getTemplateInstantiations()`
/home/runner/work/cppcheck/cppcheck/lib/templatesimplifier.cpp:824:42: error: Loss of sign in implicit conversion [clang-analyzer-alpha.core.Conversion,-warnings-as-errors]
824 | const unsigned int pos = getTemplateNamePosition(tok);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Collaborator
Author
|
I am pretty sure one of the compiler warnings we are too smart for to enable would have caught this as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.