Skip to content

fixed #13743 - FP AssignmentAddressToInteger for double cast#7417

Merged
chrchr-github merged 3 commits intocppcheck-opensource:mainfrom
firewave:up-prop-zz
Apr 2, 2025
Merged

fixed #13743 - FP AssignmentAddressToInteger for double cast#7417
chrchr-github merged 3 commits intocppcheck-opensource:mainfrom
firewave:up-prop-zz

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

@firewave

This comment was marked as resolved.

Comment thread test/testtoken.cpp
Comment on lines -1347 to -1348
tok.varId(17);
tok.str("var1");
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str() clears the varid so this test was pointless.

@firewave firewave force-pushed the up-prop-zz branch 2 times, most recently from 18cb901 to 59360ae Compare April 1, 2025 20:29
@firewave firewave marked this pull request as ready for review April 1, 2025 20:30
Comment thread test/testtokenize.cpp
ASSERT_EQUALS("void ( * const f ) ( ) ;", tokenizeAndStringify("typedef void (*fp_t)(); fp_t const f;"));
}

void simplifyPlatformTypes() {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these tests go here? #7416

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They used to be there but I included them here to have more coverage of the various parts of the code which triggered the issue.

@chrchr-github chrchr-github merged commit 77b76aa into cppcheck-opensource:main Apr 2, 2025
60 checks passed
@firewave firewave deleted the up-prop-zz branch April 2, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants