Skip to content

cfg/kde.cfg - add more KDE macros that are widely used#7447

Merged
chrchr-github merged 1 commit intocppcheck-opensource:mainfrom
winterz:main
Apr 13, 2025
Merged

cfg/kde.cfg - add more KDE macros that are widely used#7447
chrchr-github merged 1 commit intocppcheck-opensource:mainfrom
winterz:main

Conversation

@winterz
Copy link
Copy Markdown
Contributor

@winterz winterz commented Apr 8, 2025

No description provided.

@chrchr-github
Copy link
Copy Markdown
Collaborator

Thanks for your contribution. Can you add some test code in test/cfg/kde.cpp?

@winterz
Copy link
Copy Markdown
Contributor Author

winterz commented Apr 9, 2025

Thanks for your contribution. Can you add some test code in test/cfg/kde.cpp?

ok.
Am I permitted to use Qt constructs in the kde.cpp file? i.e. require '--library=qt'

@winterz
Copy link
Copy Markdown
Contributor Author

winterz commented Apr 9, 2025

test program updated. it does require Qt though

@chrchr-github
Copy link
Copy Markdown
Collaborator

@winterz
Copy link
Copy Markdown
Contributor Author

winterz commented Apr 10, 2025

Probably --library=qt is required here: https://github.com/danmar/cppcheck/blob/6d61fb60f119ff192c56bd49e96e97bc6f6f7ed4/test/cfg/runtests.sh#L510C13-L510C77

my last push includes that yet the CI is still failing.
I'm not sure what's missing

@chrchr-github
Copy link
Copy Markdown
Collaborator

my last push includes that yet the CI is still failing. I'm not sure what's missing

I must have missed that. Maybe omit the quotes around "qt"?

@chrchr-github
Copy link
Copy Markdown
Collaborator

@firewave Do you have any idea?

@firewave
Copy link
Copy Markdown
Collaborator

You also need to adjust test/CMakeLists,txt.

@winterz
Copy link
Copy Markdown
Contributor Author

winterz commented Apr 12, 2025

thanks @firewave , adjusting test/CMakeLists.txt seems to have worked

@firewave
Copy link
Copy Markdown
Collaborator

thanks @firewave , adjusting test/CMakeLists.txt seems to have worked

It has to, because that code is the (basic) CMake implementation of runtest.sh. They have to be kept in sync. Before anyone asks why we have two. The CMake one is more basic and portable, and the Shell one has more (non-portable) functionality.

@winterz
Copy link
Copy Markdown
Contributor Author

winterz commented Apr 13, 2025

great. can someone with write permission merge this please?

@chrchr-github chrchr-github merged commit 52bfef4 into cppcheck-opensource:main Apr 13, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants