cmake/cxx11.cmake: dropped explicit setting of C++17 for Visual Studio with Qt6#7464
Merged
chrchr-github merged 1 commit intocppcheck-opensource:mainfrom Apr 14, 2025
Merged
Conversation
Collaborator
Author
|
I realized this while researching an issue with clang-tidy apparently using the the wrong C++ standard for the analysis. Since the build is working now and it was not happening on all runners, I assume this behavior is controlled by files included in CMake and not all runners had the same CMake version at the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is not necessary since CMake is setting C++17 for the GUI files (regardless of the compiler)