refs #13914 - apply enforced language for non-project inputs in GUI#7627
refs #13914 - apply enforced language for non-project inputs in GUI#7627firewave merged 2 commits intocppcheck-opensource:mainfrom
Conversation
| clearResults(); | ||
| mUI->mResults->checkingStarted(1); | ||
| // TODO: apply enforcedLanguage | ||
| // TODO: apply enforcedLanguage? |
There was a problem hiding this comment.
This is invoked by the Scratchpad which has it's own field for specifying the language so I think it should not be using the enforced language.
But I wonder if it relies on other project settings? If it does it would be inconsistent and we should remove that field for specifying a file name. If not it would have limited usability because it might require e.g. the standard or libraries to be set. But I guess that should get its own ticket and is not in the scope of this PR.
There was a problem hiding this comment.
I filed https://trac.cppcheck.net/ticket/13976 about this.
| // TODO: split ErrorLogger from ThreadResult | ||
| // Initialize dummy ThreadResult as ErrorLogger | ||
| ThreadResult result; | ||
| result.setFiles(QStringList(filename)); |
There was a problem hiding this comment.
This was not necessary as this is just a dummy. Also the language is identified below.
| std::list<FileWithDetails> fdetails = enrichFilesForAnalysis(fileNames, checkSettings); | ||
|
|
||
| mThread->setFiles(fileNames); | ||
| // TODO: lock UI here? |
There was a problem hiding this comment.
The UI is locked earlier in the other instance. Something to look into later (or to consider if ever fixing some issues with it).
|
please look at the conflict. |
Done. |
2 participants
No description provided.