Fix #13970 cfg/qt.cfg - add definition for QDate::isValid()#7630
Merged
chrchr-github merged 1 commit intocppcheck-opensource:mainfrom Jun 28, 2025
Merged
Conversation
Collaborator
|
Does this solve an issue for you? The existing definition already claims to handle both overloads via the |
Contributor
Author
|
with the current definition the following code snippet gives a false positive assertWithSideEffect QDate::isValid() doesn't muck with |
Collaborator
|
Then you should add |
Collaborator
|
Side note: The attribute |
winterz
force-pushed
the
work/winterz/cfg_qdate_isvalid
branch
from
1041a92 to
a61995c
Compare
to solve a false positive: ``` QDate date; Q_ASSERT(date.isValid()); ``` reports assertWithSideEffect
winterz
force-pushed
the
work/winterz/cfg_qdate_isvalid
branch
from
a61995c to
2c56f9f
Compare
chrchr-github
changed the title
chrchr-github
merged commit ca83f56
into
cppcheck-opensource:main
53 of 54 checks passed
winterz
added a commit
to winterz/cppcheck
that referenced
this pull request
Jun 30, 2025
…-opensource#7630) Add the bool isValid() signature. bool isValid(int, int, int) is already there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the bool isValid() signature.
bool isValid(int, int, int) is already there.