fixed #14002 - added missing Boost include for testrunner#7660
fixed #14002 - added missing Boost include for testrunner#7660chrchr-github merged 1 commit intocppcheck-opensource:mainfrom
testrunner#7660Conversation
firewave
changed the title
testrunner
|
See https://github.com/danmar/cppcheck/actions/runs/16191580303 for failed builds with the newly added job and no fix applied. |
|
#7658 will fix the issue with boost. |
| target_externals_include_directories(testrunner PRIVATE ${PROJECT_SOURCE_DIR}/externals/simplecpp/) | ||
| if (Boost_FOUND) | ||
| target_include_directories(testrunner SYSTEM PRIVATE ${Boost_INCLUDE_DIRS}) | ||
| endif() |
There was a problem hiding this comment.
Having to updated all the consumers when dependencies change is very fragile and error-prone. #7658 fixes that issue.
There was a problem hiding this comment.
Yes, but that should not be merged so close to the release. And fixing such a minor issue within implicitly in a major rework is not great.
There was a problem hiding this comment.
Its always a small fix while technical debt piles up. Its best to take the opportunity to fix the issue once and for all.
pfultz2
left a comment
pfultz2
left a comment
There was a problem hiding this comment.
We can merge this for the short-term.
|
@danmar @orbitcowboy @chrchr-github Can you merge this? |
3 participants
fixes build with Boost installed in non-default system include dir