fix #13431: consolidate CLI options for XML output format#7700
fix #13431: consolidate CLI options for XML output format#7700danmar merged 5 commits intocppcheck-opensource:mainfrom
Conversation
|
| " * text\n" | ||
| " * sarif\n" | ||
| " * xml\n" | ||
| " * xml (deprecated)\n" |
There was a problem hiding this comment.
Since this is deprecated we should show a message to the user about it when used and determine a version when this will be removed. As xmlv2 has been the default for a long time already I think it should be fine if this is removed in 2.20. The import code in the GUI and htmlreport should also reflect that.
Maybe also mention that text is the default.
We should also have a releasenotes.txt entry and ticket for the deprecation. And another for the planned removal.
Given the additional scope the whole deprecation thing should be done in a follow-up PR though.
There was a problem hiding this comment.
The --xml* options should be deprecated as well but I would not do that until we can show the CLI messages as findings.
There was a problem hiding this comment.
The --xml* options should be deprecated as well but I would not do that until we can show the CLI messages as findings.
not sure why we would deprecate those? it would break A LOT of scripts to remove them. we can just hide them from the --help output.
There was a problem hiding this comment.
I filed https://trac.cppcheck.net/ticket/14055 and https://trac.cppcheck.net/ticket/14056 about this.
not sure why we would deprecate those?
So we do not have multiple ways to achieve the same. Also so the logic added here is not actually necessary.
3 participants
No description provided.