Skip to content

avoid -Wuseless-cast GCC warnings in Qt mocs#7751

Merged
chrchr-github merged 1 commit intocppcheck-opensource:mainfrom
firewave:moc-useless-cast
Aug 19, 2025
Merged

avoid -Wuseless-cast GCC warnings in Qt mocs#7751
chrchr-github merged 1 commit intocppcheck-opensource:mainfrom
firewave:moc-useless-cast

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

example:

/home/runner/work/cppcheck/cppcheck/cmake.output.tinyxml2/gui/test/resultstree/__/__/moc_threadhandler.cpp: In static member function ‘static void ThreadHandler::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’:
/home/runner/work/cppcheck/cppcheck/cmake.output.tinyxml2/gui/test/resultstree/__/__/moc_threadhandler.cpp:100:51: error: useless cast to type ‘using _t = void (class ThreadHandler::*)()’ {aka ‘void (class ThreadHandler::*)()’} [-Werror=useless-cast]
  100 |             if (*reinterpret_cast<_t *>(_a[1]) == static_cast<_t>(&ThreadHandler::done)) {
      |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

example:
```
/home/runner/work/cppcheck/cppcheck/cmake.output.tinyxml2/gui/test/resultstree/__/__/moc_threadhandler.cpp: In static member function ‘static void ThreadHandler::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’:
/home/runner/work/cppcheck/cppcheck/cmake.output.tinyxml2/gui/test/resultstree/__/__/moc_threadhandler.cpp:100:51: error: useless cast to type ‘using _t = void (class ThreadHandler::*)()’ {aka ‘void (class ThreadHandler::*)()’} [-Werror=useless-cast]
  100 |             if (*reinterpret_cast<_t *>(_a[1]) == static_cast<_t>(&ThreadHandler::done)) {
      |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
@sonarqubecloud
Copy link
Copy Markdown

@firewave firewave changed the title avoid -Wuseless-cast GCC warnings in mocs avoid -Wuseless-cast GCC warnings in Qt mocs Aug 19, 2025
@chrchr-github chrchr-github merged commit 8d388dc into cppcheck-opensource:main Aug 19, 2025
63 checks passed
@firewave firewave deleted the moc-useless-cast branch August 19, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants