Address comments in PR#794 and alternative fix for ticket #7500.#796
Merged
amai2012 merged 1 commit intoMay 21, 2016
Merged
Conversation
simartin
referenced
this pull request
May 20, 2016
| // clang and gcc seem to use the following encoding: 'AB' as (('A' << 8) | 'B') | ||
| const std::string& normStr = normalizeCharacterLiteral(str); | ||
| if (normStr.empty()) | ||
| throw InternalError(0, "Internal Error. MathLib::characterLiteralToLongNumber: Unhandled char constant '" + str + "'."); |
Collaborator
There was a problem hiding this comment.
Maybe keep that security check? normalizeCharacterLiteral() is non-trivial, maybe it can still fail somehow or after some future modifications.
Contributor
Author
There was a problem hiding this comment.
I see the semantics of normalizeCharacterLiteral as "give me a valid literal or throw". Should we encounter crashes in the future, I'd rather we fix normalizeCharacterLiteral than leave them go unnoticed.
Collaborator
|
Ok, let's try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the remark @amai2012 made in 3af30e7 and implements an alternative fix (IMHO better) for ticket #7500.
Simon