htmlreport: preserve filter state when navigating back/forward#7993
Merged
danmar merged 1 commit intocppcheck-opensource:mainfrom Dec 10, 2025
rgetz:rgetz-fix-html-back
Merged
htmlreport: preserve filter state when navigating back/forward#7993danmar merged 1 commit intocppcheck-opensource:mainfrom rgetz:rgetz-fix-html-back
danmar merged 1 commit intocppcheck-opensource:mainfrom
rgetz:rgetz-fix-html-back
Conversation
Currently, using browser back/forward buttons resets filtered issue lists, even though checkbox states persist. This is confusing and makes it hard to see the filtered results consistently. Changes: - Added a `reapplyFilters()` function that reapplies ID, severity, classification, and tool filters based on the current checkbox states. - Hooked `reapplyFilters()` to the `pageshow` event to restore filtered classes when navigating with back/forward.
|
Contributor
Author
|
@danmar - sorry to poke you about this one - this makes the html reports much more usable for me... |
danmar
approved these changes
Dec 10, 2025
Collaborator
|
please ping me if I don't review in a week or two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, using browser back/forward buttons resets filtered issue lists, even though checkbox states persist. This is confusing and makes it hard to see the filtered results consistently.
Changes:
reapplyFilters()function that reapplies ID, severity, classification, and tool filters based on the current checkbox states.reapplyFilters()to thepageshowevent to restore filtered classes when navigating with back/forward.Tested on Chrome (144.0.7534.0 (Official Build) dev (64-bit))