Fix #14305 Wrong buffer sizes computed by valueFlowDynamicBufferSize()

[chrchr-github]

No description provided.

[danmar]

I do not see why we want to have different results from ValueType::typeSize and ValueFlow::getSizeOf. Can you explain it? Did you consider refactoring so that ValueType::typeSize calls ValueFlow::getSizeOf or vice versa?

[chrchr-github]

I do not see why we want to have different results from ValueType::typeSize and ValueFlow::getSizeOf. Can you explain it? Did you consider refactoring so that ValueType::typeSize calls ValueFlow::getSizeOf or vice versa?

Yes, having those two functions is unfortunate, and they should be merged.
The main difference is that ValueType::typeSize returns the size of the pointed-to type by default (controlled by the p parameter). Also, ValueType::typeSize doesn't seem to work for user-defined types (it returns typeScope->definedType->sizeOf, which seems to only get set by clang import.

[chrchr-github]

BTW, is daca down? I haven't been able to connect to http://cppcheck1.osuosl.org:8000/ for a while.

[firewave]

BTW, is daca down? I haven't been able to connect to http://cppcheck1.osuosl.org:8000/ for a while.

The server did not start up because the package index was corrupted. It is fixed now.

[firewave]

The server did not start up because the package index was corrupted. It is fixed now.

Clients process data again.

lua-svn                                  2025-11-27 18:18      34      34         
0install-solver                          2025-12-07 23:38       8       8

Had been broken for over a week.

[chrchr-github]

This was already incorrect before.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarQube Cloud