Fix #13877 FP constParameterReference when casting to derived class#8041
Merged
chrchr-github merged 3 commits intocppcheck-opensource:mainfrom Jan 2, 2026
Merged
Fix #13877 FP constParameterReference when casting to derived class#8041chrchr-github merged 3 commits intocppcheck-opensource:mainfrom
chrchr-github merged 3 commits intocppcheck-opensource:mainfrom
Conversation
|
chrchr-github
added
the
merge-after-next-release
danmar
reviewed
Dec 18, 2025
| auto expr = getExprTok(); | ||
| if (!expr && !(tok->valueType() && tok->valueType()->pointer == 0 && tok->valueType()->reference == Reference::None)) | ||
| aliased = true; | ||
| if (!aliased && expr && expr->varId() && tok->isCast() && tok->valueType() && tok->valueType()->reference != Reference::None && |
Collaborator
There was a problem hiding this comment.
Would it make sense to move this condition into isAliasOf?
Collaborator
Author
There was a problem hiding this comment.
Not sure, isAliasOf() currently only relies on ValueFlow. @pfultz2
We have some more FPs related to this logic.
danmar
approved these changes
Jan 2, 2026
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I have no strong opinion about isAliasOf. If it just works and makes isAliasOf better.. then I like the idea.
Feel free to merge if you want.
Collaborator
Author
|
@danmar It looks like daca is down again. Could you please check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.