Skip to content

Fix #14808 FN leakNoVarFunctionCall with new #8611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 3 commits into from
Jun 2, 2026
+18 −0
Merged

Fix #14808 FN leakNoVarFunctionCall with new #8611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebaa7ce
Update checkmemoryleak.cpp
chrchr-github Jun 1, 2026
2ccefce
Update testmemleak.cpp
chrchr-github Jun 1, 2026
793e68f
Update checkmemoryleak.cpp
chrchr-github Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/checkmemoryleak.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,6 +1052,9 @@ void CheckMemoryLeakNoVarImpl::checkForUnreleasedInputArgument(const Scope *scop
if (alloc == New || alloc == NewArray) {
const Token* typeTok = arg->next();
bool bail = !typeTok->isStandardType() &&
(!typeTok->valueType() ||
(typeTok->valueType()->type < ValueType::Type::SMART_POINTER &&
typeTok->valueType()->type != ValueType::Type::POD)) &&
!mSettings.library.detectContainerOrIterator(typeTok) &&
!mSettings.library.podtype(typeTok->expressionString());
if (bail && typeTok->type() && typeTok->type()->classScope &&
Expand Down
15 changes: 15 additions & 0 deletions test/testmemleak.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2613,6 +2613,21 @@ class TestMemleakNoVar : public TestFixture {
ASSERT_EQUALS("[test.cpp:2:19]: (error) Allocation with new, strlen doesn't release it. [leakNoVarFunctionCall]\n"
"[test.cpp:5:20]: (error) Allocation with new, strlen doesn't release it. [leakNoVarFunctionCall]\n",
errout_str());

check("int* f1() { return new int; }\n" // #14808
"std::string* f2() { return new std::string(\"abc\"); }\n"
"std::clock_t* f3() { return new std::clock_t; }\n"
"QWidget* f4(QObject* parent) { return new QWidget(parent); }\n"
"void g(QObject* parent) {\n"
" assert(f1());\n"
" assert(f2());\n"
" assert(f3());\n"
" assert(f4(parent));\n"
"}\n");
ASSERT_EQUALS("[test.cpp:6:12]: (error) Allocation with f1, assert doesn't release it. [leakNoVarFunctionCall]\n"
"[test.cpp:7:12]: (error) Allocation with f2, assert doesn't release it. [leakNoVarFunctionCall]\n"
"[test.cpp:8:12]: (error) Allocation with f3, assert doesn't release it. [leakNoVarFunctionCall]\n",
errout_str());
}

void missingAssignment() {
Expand Down
Loading