cleaned and fixed up TokenList/Macro copy/move constructor/assignment#167
Merged
danmar merged 1 commit intocppcheck-opensource:masterfrom Feb 13, 2022
Merged
Conversation
danmar
reviewed
May 5, 2019
|
|
||
| simplecpp::TokenList::TokenList(std::istream &istr, std::vector<std::string> &filenames, const std::string &filename, OutputList *outputList) | ||
| : frontToken(NULL), backToken(NULL), files(filenames) | ||
| : TokenList(filenames) |
Collaborator
There was a problem hiding this comment.
delegated constructors is a C++11 feature.
Collaborator
Author
There was a problem hiding this comment.
sure... when I am done with the anniversary cake 🎂
firewave
force-pushed
the
ctor-assign
branch
from
80e4de0 to
7b7809b
Compare
danmar
reviewed
Feb 13, 2022
| other.backToken = nullptr; | ||
| frontToken = other.frontToken; | ||
| other.frontToken = nullptr; | ||
| frontToken = other.frontToken; |
Collaborator
Author
There was a problem hiding this comment.
Done. Somehow my IDE suddenly doesn't do "smart tabs" anymore.
firewave
force-pushed
the
ctor-assign
branch
from
7b7809b to
7c4b658
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.