fixed and enabled -Wold-style-cast#235
Merged
danmar merged 1 commit intocppcheck-opensource:masterfrom Feb 16, 2022
Merged
Conversation
danmar
reviewed
Feb 13, 2022
| # these are not really fixable | ||
| add_compile_options(-Wno-exit-time-destructors -Wno-global-constructors) | ||
| # TODO: fix these? | ||
| add_compile_options(-Wno-padded -Wno-sign-conversion -Wno-conversion -Wno-old-style-cast) |
Collaborator
There was a problem hiding this comment.
I don't want to get conversion warnings. I am not sure what the Wpadded is about.
Collaborator
Author
There was a problem hiding this comment.
I will address that in another PR.
The one about padding is related the the order of member in a data types causing additional padding and thus increased memory usage. In general it's also something we might not be interested in.
firewave
force-pushed
the
old-style-cast
branch
from
9302a87 to
6f7eb2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.