Skip to content

replace 'isspace' with 'std::isspace'#370

Merged
danmar merged 1 commit intomasterfrom
isspace
Sep 28, 2024
Merged

replace 'isspace' with 'std::isspace'#370
danmar merged 1 commit intomasterfrom
isspace

Conversation

@danmar
Copy link
Copy Markdown
Collaborator

@danmar danmar commented Sep 28, 2024

I have the feeling that isspace is not portable. We include cctype.

@danmar danmar merged commit 26b6431 into master Sep 28, 2024
@firewave
Copy link
Copy Markdown
Collaborator

It should be. These C functions exists within and outside the namespace.

@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Sep 28, 2024

At least an old C++ Builder did not include ctype.h from cctype but well that was more than 10 years ago. I don't explicitly see that isspace is available in cctype in cppreference i.e. https://en.cppreference.com/w/c/string/byte/isspace.

@firewave
Copy link
Copy Markdown
Collaborator

Because you looked at the C standard description. See https://en.cppreference.com/w/cpp/string/byte/isspace for the C++ one.

@danmar
Copy link
Copy Markdown
Collaborator Author

danmar commented Sep 30, 2024

yes as far as I understand that only mentions std::isspace .

I compare the text with https://en.cppreference.com/w/cpp/container/vector that does not always provide std:: explicitly.

@danmar danmar deleted the isspace branch December 11, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants