fix: getting cppcheck version throws an exception #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
reviewed
Apr 2, 2024
...ecode.cppcheclipse.core/src/com/googlecode/cppcheclipse/core/command/UpdateCheckCommand.java
Outdated
Show resolved
Hide resolved
This commit adds premium versions parsing and queries different urls for updaes, based on cppcheck version reported.
danmar
reviewed
Apr 5, 2024
...lecode.cppcheclipse.core.tests/src/com/googlecode/cppcheclipse/core/command/TestVersion.java
Show resolved
Hide resolved
...ecode.cppcheclipse.core/src/com/googlecode/cppcheclipse/core/command/UpdateCheckCommand.java
Show resolved
Hide resolved
com.googlecode.cppcheclipse.core/src/com/googlecode/cppcheclipse/core/command/Version.java
Outdated
Show resolved
Hide resolved
danmar
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http endpoint is not valid anymore.
This PR also adds premium versions parsing and queries different urls for updates, based on cppcheck version
reported.
More, the redirect HTTP 301 return code wasn't handled at all, hence the update checker was failing constantly.