Skip to content

fix: onStart triggered by pending roll start#1978

Merged
cpvalente merged 1 commit intomasterfrom
fix-onstart
Feb 28, 2026
Merged

fix: onStart triggered by pending roll start#1978
cpvalente merged 1 commit intomasterfrom
fix-onstart

Conversation

@cpvalente
Copy link
Owner

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-onstart

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cpvalente cpvalente requested a review from alex-Arc February 23, 2026 05:49
@alex-Arc
Copy link
Collaborator

I can't quite find the way to reproduce the original issue?

@cpvalente
Copy link
Owner Author

I can't quite find the way to reproduce the original issue?

If we go into roll from a waiting to roll timer the trigger was not called

@cpvalente cpvalente merged commit 1fe58e2 into master Feb 28, 2026
4 checks passed
@cpvalente cpvalente deleted the fix-onstart branch February 28, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants