Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the Electron packaging configuration/assets to improve macOS (Tahoe) icon compatibility, alongside the dependency/lockfile changes required to support the new build setup.
Changes:
- Bump
electron-builderto26.8.1and refreshpnpm-lock.yamlaccordingly. - Switch macOS build icon configuration from
icon.icnsto the newontime.iconbundle. - Add the
apps/electron/src/assets/ontime.icon/icon.jsonasset metadata (for the new icon bundle).
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile refresh to support the electron-builder update and updated transitive dependency graph. |
| apps/electron/src/assets/ontime.icon/icon.json | Adds the new .icon bundle metadata referenced by the Electron build config. |
| apps/electron/package.json | Updates electron-builder version and points macOS build icon to ontime.icon. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| '@vitejs/plugin-react': | ||
| specifier: 4.5.1 | ||
| version: 4.5.1(vite@6.3.1(@types/node@22.15.26)(jiti@2.4.2)(sass@1.92.0)(tsx@4.20.5)) | ||
| version: 4.5.1(vite@6.3.1(@types/node@25.4.0)(jiti@2.6.1)(sass@1.92.0)(tsx@4.20.5)) |
There was a problem hiding this comment.
In the apps/client importer, Vite/Vitest are now resolved against @types/node@25.4.0, even though the workspace catalog pins @types/node to 22.15.26 (and the repo engine is Node ~22). If the intent is to keep Node typings aligned across the monorepo, consider adding an explicit @types/node: catalog: devDependency to apps/client or using a pnpm override to prevent pulling in a newer @types/node via transitive/optional deps.
Adds new icon format for mac, as mentioned in #1999
https://www.electron.build/icons.html