Skip to content

refactor: icon compatibility with macos tahoe#2000

Merged
cpvalente merged 1 commit intomasterfrom
fix-icons
Mar 13, 2026
Merged

refactor: icon compatibility with macos tahoe#2000
cpvalente merged 1 commit intomasterfrom
fix-icons

Conversation

@cpvalente
Copy link
Owner

@cpvalente cpvalente commented Mar 11, 2026

Adds new icon format for mac, as mentioned in #1999
https://www.electron.build/icons.html

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19957461-373c-4a1e-a6f4-38eeb5aa9372

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Electron packaging configuration/assets to improve macOS (Tahoe) icon compatibility, alongside the dependency/lockfile changes required to support the new build setup.

Changes:

  • Bump electron-builder to 26.8.1 and refresh pnpm-lock.yaml accordingly.
  • Switch macOS build icon configuration from icon.icns to the new ontime.icon bundle.
  • Add the apps/electron/src/assets/ontime.icon/icon.json asset metadata (for the new icon bundle).

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
pnpm-lock.yaml Lockfile refresh to support the electron-builder update and updated transitive dependency graph.
apps/electron/src/assets/ontime.icon/icon.json Adds the new .icon bundle metadata referenced by the Electron build config.
apps/electron/package.json Updates electron-builder version and points macOS build icon to ontime.icon.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 155 to +157
'@vitejs/plugin-react':
specifier: 4.5.1
version: 4.5.1(vite@6.3.1(@types/node@22.15.26)(jiti@2.4.2)(sass@1.92.0)(tsx@4.20.5))
version: 4.5.1(vite@6.3.1(@types/node@25.4.0)(jiti@2.6.1)(sass@1.92.0)(tsx@4.20.5))
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the apps/client importer, Vite/Vitest are now resolved against @types/node@25.4.0, even though the workspace catalog pins @types/node to 22.15.26 (and the repo engine is Node ~22). If the intent is to keep Node typings aligned across the monorepo, consider adding an explicit @types/node: catalog: devDependency to apps/client or using a pnpm override to prevent pulling in a newer @types/node via transitive/optional deps.

Copilot uses AI. Check for mistakes.
@cpvalente cpvalente merged commit a7a7870 into master Mar 13, 2026
8 checks passed
@cpvalente cpvalente deleted the fix-icons branch March 13, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants