adds dokka support to generate javadocs for the kotlin only projects#118
Merged
brynrhodes merged 1 commit intomasterfrom Mar 27, 2026
Merged
adds dokka support to generate javadocs for the kotlin only projects#118brynrhodes merged 1 commit intomasterfrom
brynrhodes merged 1 commit intomasterfrom
Conversation
… needed by maven central
|
Formatting check succeeded! |
Coverage Report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage 75.25% 75.25%
Complexity 365 365
=========================================
Files 44 44
Lines 1160 1160
Branches 171 171
=========================================
Hits 873 873
Misses 189 189
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brynrhodes
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maven Central requires javadoc files for every project, even if the javadoc file is empty there still has to be one pro-project.
The build process for some of the cql-language-server projects still generated javadoc files.
Unforunately, the cql-ls-service and cql-ls-debug-service do not. Those projects use main.kt as entry points and teh shading plugin interferes with the javadoc plugin. This doesn't affect the jar executable, just doesn't create the needed javadoc files. This cauased maven central to reject those projects because of the missing javadoc files.
The PR adds the dokka plugin which generates javadocs for kotlin only projects.