feat: report the number of dropped events to sentry#226
Merged
CrabNejonas merged 2 commits intomainfrom Feb 8, 2024
Merged
Conversation
CrabNejonas
requested review from
atila-crabnebula,
johann-crabnebula and
tejas-crabnebula
as code owners
✅ Deploy Preview for cn-devtools-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johann-crabnebula
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a two-line change that forwards the number of spans/events the rust instrumentation had to drop bc it was running out of buffer space. This is helpful for us to tweak the internal settings and important for end users since dropped events equal data loss and that is a bad experience all around.