Skip to content

fix: remove health stream usage #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasfernog-crabnebula merged 1 commit into from
Apr 26, 2024
Merged

fix: remove health stream usage #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions clients/web/src/components/health-status.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,7 @@ const variant = (status: HealthCheckResponse_ServingStatus) => {
export function HealthStatus() {
const updateErrorHandler = () => {
console.error("an error happened on Updates Stream");
// if (isConnectionDead()) {
/**
* we do nothing because it's not an instrumentation issue.
*/
return;
// }
};

const healthErrorHandler = () => {
console.error("an error happened on Health Stream");
setMonitorData("health", 0);
setConnectionDead(true);

Expand All @@ -57,7 +48,6 @@ export function HealthStatus() {
attempts: 5,
});
};

/* undefined = failed to reconnect
-1 = reconnecting
> 0 = time until reconnect
Expand Down Expand Up @@ -139,7 +129,6 @@ export function HealthStatus() {
monitorData,
);

connectionStore.stream.health.responses.onError(healthErrorHandler);
connectionStore.stream.update.responses.onError(updateErrorHandler);
}

Expand All @@ -148,7 +137,6 @@ export function HealthStatus() {
const [isConnectionDead, setConnectionDead] = createSignal(false);

onMount(() => {
connectionStore.stream.health.responses.onError(healthErrorHandler);
connectionStore.stream.update.responses.onError(updateErrorHandler);
});

Expand Down
7 changes: 0 additions & 7 deletions clients/web/src/lib/connection/transport.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ export function connect(url: string) {
const sourcesClient = new SourcesClient(transport);
const metaClient = new MetadataClient(transport);

const healthStream = healthClient.watch(
/**
* empty string means all services.
*/
HealthCheckRequest.create({ service: "" }),
);
const updateStream = instrumentClient.watchUpdates(
InstrumentRequest.create({}),
);
Expand All @@ -84,7 +78,6 @@ export function connect(url: string) {
meta: metaClient,
},
stream: {
health: healthStream,
update: updateStream,
},
};
Expand Down